-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support resumability of DynamoDB migrations #190
Conversation
a411f60
to
95c9e34
Compare
I guess this feature requires more thorough testing. Ideally, we should have a dedicated page on the documentation to describe precisely what the users would see and what they should do. And also to explain clearly the limitations of the current implementation. |
I performed another test this morning with the following scenario:
I then performed the following variation:
|
95c9e34
to
feeb7b5
Compare
813a2ea
to
b1c4589
Compare
@tarzanek ping |
All the PRs that this PR depends on have been merged. We now need to cut a new release of the emr-dynamodb-connector to unblock this PR. I will work on that ASAP. |
Great, thanks! |
- Track in savepoint files the scan segments that have been fully migrated - Generalize the savepoints management to support both CQL and DynamoDB - Update documentation accordingly Fixes scylladb#165
b1c4589
to
7d006a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I like the manager superclass, this way it will be easy to fix anything for both cases
scanSegments: 3
andskipSegments: [1, 2]
)scanSegments: 3
andskipSegments: [0]
)The limitations are that we don’t test that the savepoints are correctly created. I am not sure how to properly test that since this is time sensitive.
Fixes #165
Blocked by
#183andscylladb/emr-dynamodb-connector#7.